Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940521AbdDSXkJ (ORCPT ); Wed, 19 Apr 2017 19:40:09 -0400 Received: from foss.arm.com ([217.140.101.70]:48340 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940278AbdDSXkH (ORCPT ); Wed, 19 Apr 2017 19:40:07 -0400 Subject: Re: [PATCH v4 04/18] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon To: Corentin Labbe , robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, peppe.cavallaro@st.com, alexandre.torgue@st.com References: <20170412111400.2296-1-clabbe.montjoie@gmail.com> <20170412111400.2296-5-clabbe.montjoie@gmail.com> Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org From: =?UTF-8?Q?Andr=c3=a9_Przywara?= Organization: ARM Ltd. Message-ID: <9382f9ae-895a-397b-3d8c-846cb0bc4486@arm.com> Date: Thu, 20 Apr 2017 00:38:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170412111400.2296-5-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1787 Lines: 49 On 12/04/17 12:13, Corentin Labbe wrote: > This patch adds documentation for Device-Tree bindings for the > syscon present in allwinner devices. > > Signed-off-by: Corentin Labbe > --- > .../devicetree/bindings/misc/allwinner,syscon.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/allwinner,syscon.txt > > diff --git a/Documentation/devicetree/bindings/misc/allwinner,syscon.txt b/Documentation/devicetree/bindings/misc/allwinner,syscon.txt > new file mode 100644 > index 0000000..c056c5b > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/allwinner,syscon.txt > @@ -0,0 +1,19 @@ > +* Allwinner sun8i system controller > + > +This file describes the bindings for the system controller present in > +Allwinner SoC H3, A83T and A64. > +The principal function of this syscon is to control EMAC PHY choice and > +config. > + > +Required properties for the system controller: > +- reg: address and length of the register for the device. > +- compatible: should be "syscon" and one of the following string: > + "allwinner,sun8i-h3-system-controller" > + "allwinner,sun8i-a64-system-controller" While sun8i might make some sense technically, all 64-bit sunxi compatible strings use the sun50i prefix to follow the Allwinner naming. So this should read: "allwinner,sun50i-a64-system-controller" Also I am wondering if we should add a compatible string for the H5 (support for that SoC is in -next already): "allwinner,sun50i-h5-system-controller" Cheers, Andre. > + "allwinner,sun8i-a83t-system-controller" > + > +Example: > +syscon: syscon@01c00000 { > + compatible = "allwinner,sun8i-h3-system-controller", "syscon"; > + reg = <0x01c00000 0x1000>; > +}; >