Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968616AbdDSX4u (ORCPT ); Wed, 19 Apr 2017 19:56:50 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:33128 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968569AbdDSX4s (ORCPT ); Wed, 19 Apr 2017 19:56:48 -0400 Date: Wed, 19 Apr 2017 18:56:46 -0500 From: Rob Herring To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Wolfram Sang , linux-arm-kernel@lists.infradead.org, =?iso-8859-1?Q?Beno=EEt?= Cousson , devicetree@vger.kernel.org, Tony Lindgren , Mark Rutland , linux-omap@vger.kernel.org, Russell King , Mark Jackson Subject: Re: [PATCH v3 03/21] ARM: dts: omap: Add generic compatible string for I2C EEPROM Message-ID: <20170419235646.j6cc3vm7eru6buv6@rob-hp-laptop> References: <20170414010445.21727-1-javier@osg.samsung.com> <20170414010445.21727-4-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170414010445.21727-4-javier@osg.samsung.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2515 Lines: 56 On Thu, Apr 13, 2017 at 10:04:27PM -0300, Javier Martinez Canillas wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas > --- > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/am335x-baltos.dtsi | 2 +- > arch/arm/boot/dts/am335x-base0033.dts | 2 +- > arch/arm/boot/dts/am335x-bone-common.dtsi | 10 +++++----- > arch/arm/boot/dts/am335x-nano.dts | 2 +- > arch/arm/boot/dts/am335x-pepper.dts | 2 +- > arch/arm/boot/dts/am335x-shc.dts | 2 +- > arch/arm/boot/dts/am335x-sl50.dts | 2 +- > arch/arm/boot/dts/am437x-idk-evm.dts | 2 +- > arch/arm/boot/dts/am437x-sk-evm.dts | 2 +- > arch/arm/boot/dts/am43x-epos-evm.dts | 2 +- > arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi | 2 +- > arch/arm/boot/dts/omap3-cm-t3x.dtsi | 2 +- > arch/arm/boot/dts/omap3-gta04.dtsi | 2 +- > arch/arm/boot/dts/omap3-sb-t35.dtsi | 2 +- > arch/arm/boot/dts/omap4-var-som-om44.dtsi | 2 +- > arch/arm/boot/dts/omap5-cm-t54.dts | 2 +- > arch/arm/boot/dts/omap5-sbc-t54.dts | 2 +- > 17 files changed, 21 insertions(+), 21 deletions(-) > > diff --git a/arch/arm/boot/dts/am335x-baltos.dtsi b/arch/arm/boot/dts/am335x-baltos.dtsi > index d42b98f15e8b..6ca780d0623f 100644 > --- a/arch/arm/boot/dts/am335x-baltos.dtsi > +++ b/arch/arm/boot/dts/am335x-baltos.dtsi > @@ -255,7 +255,7 @@ > }; > > at24@50 { > - compatible = "at24,24c02"; > + compatible = "at24,24c02", "atmel,24c02"; I think you can just drop the at24 compatibles. A new kernel doesn't need it. An old kernel ignores the manufacturer. I checked that u-boot only matches on "atmel,*", so okay there. Don't know about the *BSDs. I couldn't find anything. Minimally, the deprecated compatible should come last. Rob