Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936636AbdDTClK (ORCPT ); Wed, 19 Apr 2017 22:41:10 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:22700 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936041AbdDTClI (ORCPT ); Wed, 19 Apr 2017 22:41:08 -0400 To: Dmitry Monakhov Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, martin.petersen@oracle.com Subject: Re: [PATCH 5/9] bio-integrity: fold bio_integrity_enabled to bio_integrity_prep From: "Martin K. Petersen" Organization: Oracle Corporation References: <1491332201-26926-1-git-send-email-dmonakhov@openvz.org> <1491332201-26926-6-git-send-email-dmonakhov@openvz.org> Date: Wed, 19 Apr 2017 22:40:58 -0400 In-Reply-To: <1491332201-26926-6-git-send-email-dmonakhov@openvz.org> (Dmitry Monakhov's message of "Tue, 4 Apr 2017 22:56:37 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 479 Lines: 14 Dmitry Monakhov writes: > Currently all integrity prep hooks are open-coded, and if prepare > fails we ignore it's code and fail bio with EIO. Let's return real > error to upper layer, so later caller may react accordingly. > > In fact no one want to use bio_integrity_prep() w/o > bio_integrity_enabled, so it is reasonable to fold it in to one > function. Agree with Christoph's comments. Otherwise OK. -- Martin K. Petersen Oracle Linux Engineering