Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941823AbdDTGLP (ORCPT ); Thu, 20 Apr 2017 02:11:15 -0400 Received: from ozlabs.org ([103.22.144.67]:45175 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941370AbdDTGLM (ORCPT ); Thu, 20 Apr 2017 02:11:12 -0400 From: Michael Ellerman To: "Naveen N. Rao" , Masami Hiramatsu Cc: Ananth N Mavinakayanahalli , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar Subject: Re: [PATCH v3 6/7] powerpc: kprobes: emulate instructions on kprobe handler re-entry In-Reply-To: <1492620027.h27iuc5j5o.astroid@naverao1-tp.none> References: <0d4193a90e4b2ad3cd2ef33d41228b80a2ac9f91.1492604782.git.naveen.n.rao@linux.vnet.ibm.com> <20170419234319.7893df9c158e565fede4a386@kernel.org> <1492620027.h27iuc5j5o.astroid@naverao1-tp.none> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Thu, 20 Apr 2017 16:11:10 +1000 Message-ID: <87lgqv4ni9.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 670 Lines: 20 "Naveen N. Rao" writes: > Excerpts from Masami Hiramatsu's message of April 19, 2017 20:13: >> >> BTW, as I pointed, 5/7 and 6/7 should be merged since this actually >> makes meaningful change. > > Yes, sorry if I wasn't clear in my previous reply in the (!) previous > patch series. > > Since this has to go through the powerpc tree, I followed this since I > felt that Michael Ellerman prefers to keep functional changes separate > from refactoring. I'm fine with either approach. > > Michael? Yeah I'd definitely like this to be two patches. Otherwise when reading the combined diff it's much harder to see the change. cheers