Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030698AbdDTJxW (ORCPT ); Thu, 20 Apr 2017 05:53:22 -0400 Received: from mx2.suse.de ([195.135.220.15]:49667 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S944200AbdDTJxC (ORCPT ); Thu, 20 Apr 2017 05:53:02 -0400 Date: Thu, 20 Apr 2017 09:31:37 +0200 From: Jean Delvare To: David Howells Cc: linux-kernel@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, Wolfram Sang , gregkh@linuxfoundation.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH 09/38] Annotate hardware config module parameters in drivers/i2c/ Message-ID: <20170420093137.5d28916d@endymion> In-Reply-To: <149141148368.29162.12692004178864468110.stgit@warthog.procyon.org.uk> References: <149141141298.29162.5612793122429261720.stgit@warthog.procyon.org.uk> <149141148368.29162.12692004178864468110.stgit@warthog.procyon.org.uk> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1445 Lines: 33 On Wed, 05 Apr 2017 17:58:03 +0100, David Howells wrote: > When the kernel is running in secure boot mode, we lock down the kernel to > prevent userspace from modifying the running kernel image. Whilst this > includes prohibiting access to things like /dev/mem, it must also prevent > access by means of configuring driver modules in such a way as to cause a > device to access or modify the kernel image. > > To this end, annotate module_param* statements that refer to hardware > configuration and indicate for future reference what type of parameter they > specify. The parameter parser in the core sees this information and can > skip such parameters with an error message if the kernel is locked down. > The module initialisation then runs as normal, but just sees whatever the > default values for those parameters is. > > Note that we do still need to do the module initialisation because some > drivers have viable defaults set in case parameters aren't specified and > some drivers support automatic configuration (e.g. PNP or PCI) in addition > to manually coded parameters. > > This patch annotates drivers in drivers/i2c/. > > Suggested-by: Alan Cox > Signed-off-by: David Howells > cc: Wolfram Sang > cc: Jean Delvare > cc: linux-i2c@vger.kernel.org > (...) Acked-by: Jean Delvare -- Jean Delvare SUSE L3 Support