Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031460AbdDTKQl (ORCPT ); Thu, 20 Apr 2017 06:16:41 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:33490 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031261AbdDTKQi (ORCPT ); Thu, 20 Apr 2017 06:16:38 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170416103546.3021-1-contact@paulk.fr> <1492443526.12267.4.camel@paulk.fr> <1492505196.2014.0.camel@paulk.fr> From: Geert Uytterhoeven Date: Thu, 20 Apr 2017 12:16:36 +0200 X-Google-Sender-Auth: IPWF3ADMsfcZh8mFc4AVqYSXdfk Message-ID: Subject: Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output To: Daniel Thompson Cc: Paul Kocialkowski , "linux-kernel@vger.kernel.org" , Thierry Reding , Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , Linux PWM List , Linux Fbdev development list , linux-tegra@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v3KAGphO004361 Content-Length: 1938 Lines: 52 Hi Daniel, On Thu, Apr 20, 2017 at 11:55 AM, Daniel Thompson wrote: > On 18/04/17 09:46, Paul Kocialkowski wrote: >> Le lundi 17 avril 2017 à 21:36 +0200, Geert Uytterhoeven a écrit : >>> On Mon, Apr 17, 2017 at 5:38 PM, Paul Kocialkowski >>> wrote: >>>> Le dimanche 16 avril 2017 à 22:55 +0200, Geert Uytterhoeven a écrit : >>>>> On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski >>>>> wrote: >>>>>> >>>>>> The move to a dedicated pwm_backlight_initial_power_state function in >>>>>> commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition >>>>>> to set the enable gpio as output. This breaks specific use cases using >>>>>> that GPIO, such as tegra124-based nyan Chromebooks where backlight >>>>>> stopped working. >>>>>> >>>>>> This puts the condition back to the way it was before the move. >>>>>> >>>>>> Signed-off-by: Paul Kocialkowski >>>>> >>>>> Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented >>>>> .get_direction()" >>>>> (https://lkml.org/lkml/2017/4/4/225) fix your issue? >>>> >>>> This definitely solves the issue! >>>> >>>> Since this fixes broken backlight (that, in turn, makes systems >>>> unusable), >>>> perhaps this should be included in the next rc cycle? >>> >>> You mean v4.11 final, as there probably won't be another rc? >>> Yes! >> >> I'm all for it! > > Thanks for keeping our attention on this. I sent a PR yesterday (and hope my > GPG key has attracted enough signatures). Thank you, this morning I had already noticed it went upstream. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds