Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944378AbdDTKft (ORCPT ); Thu, 20 Apr 2017 06:35:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27376 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942740AbdDTKfr (ORCPT ); Thu, 20 Apr 2017 06:35:47 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3E2272EF165 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3E2272EF165 Date: Thu, 20 Apr 2017 12:35:43 +0200 From: Jiri Olsa To: Taeung Song Cc: Jiri Olsa , Arnaldo Carvalho de Melo , David Ahern , Namhyung Kim , Peter Zijlstra , Jin Yao , lkml , Ingo Molnar Subject: Re: [PATCH perf/urgent] perf tools: Fix the code to strip command name Message-ID: <20170420103543.GA1681@krava> References: <20170420092430.29657-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 20 Apr 2017 10:35:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 756 Lines: 26 On Thu, Apr 20, 2017 at 07:17:34PM +0900, Taeung Song wrote: > Hi Jiri, > > On 04/20/2017 06:24 PM, Jiri Olsa wrote: > > Recent commit broke command name strip in perf_event__get_comm_ids > > function. It replaced left to right search for '\n' with rtrim, > > which actually does right to left search. It occasionally caught > > earlier '\n' and kept trash in the command name. > > Sorry for my commit that have failings. > > Could I know the command name in the above case ? > The command name can have two '\n' ? it's the next line in the status file.. parts of the Umask string and 1 newline Name: systemd Umask: 0000 State: S (sleeping) ... I've already posted it in here: http://marc.info/?l=linuxppc-embedded&m=149200723316270&w=2 jirka