Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944458AbdDTKmj (ORCPT ); Thu, 20 Apr 2017 06:42:39 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:35751 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940723AbdDTKmf (ORCPT ); Thu, 20 Apr 2017 06:42:35 -0400 Subject: Re: [PATCH perf/urgent] perf tools: Fix the code to strip command name To: Jiri Olsa References: <20170420092430.29657-1-jolsa@kernel.org> <20170420103543.GA1681@krava> Cc: Arnaldo Carvalho de Melo , David Ahern , Namhyung Kim , Peter Zijlstra , Jin Yao , lkml , Ingo Molnar From: Taeung Song Message-ID: <28b91633-b468-fc8b-b918-0cd5d06864e7@gmail.com> Date: Thu, 20 Apr 2017 19:42:31 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170420103543.GA1681@krava> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 36 On 04/20/2017 07:35 PM, Jiri Olsa wrote: > On Thu, Apr 20, 2017 at 07:17:34PM +0900, Taeung Song wrote: >> Hi Jiri, >> >> On 04/20/2017 06:24 PM, Jiri Olsa wrote: >>> Recent commit broke command name strip in perf_event__get_comm_ids >>> function. It replaced left to right search for '\n' with rtrim, >>> which actually does right to left search. It occasionally caught >>> earlier '\n' and kept trash in the command name. >> >> Sorry for my commit that have failings. >> >> Could I know the command name in the above case ? >> The command name can have two '\n' ? > > it's the next line in the status file.. parts of the Umask string > and 1 newline > > Name: systemd > Umask: 0000 > State: S (sleeping) > ... > > I've already posted it in here: > http://marc.info/?l=linuxppc-embedded&m=149200723316270&w=2 > > jirka > I understood it. Sorry for my mistake.. Thanks, Taeung