DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7065E7F7D4
Date: Thu, 20 Apr 2017 12:49:19 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        David Ahern <dsahern@gmail.com>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Jin Yao <yao.jin@linux.intel.com>, lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH perf/urgent] perf tools: Fix the code to strip command
 name
Message-ID: <20170420104919.GB1681@krava>
References: <20170420092430.29657-1-jolsa@kernel.org>
 <eb206d12-ab32-dfc6-5c7a-76a7daa01374@gmail.com>
 <20170420103543.GA1681@krava>
 <28b91633-b468-fc8b-b918-0cd5d06864e7@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <28b91633-b468-fc8b-b918-0cd5d06864e7@gmail.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1069
Lines: 38

On Thu, Apr 20, 2017 at 07:42:31PM +0900, Taeung Song wrote:
> 
> 
> On 04/20/2017 07:35 PM, Jiri Olsa wrote:
> > On Thu, Apr 20, 2017 at 07:17:34PM +0900, Taeung Song wrote:
> > > Hi Jiri,
> > > 
> > > On 04/20/2017 06:24 PM, Jiri Olsa wrote:
> > > > Recent commit broke command name strip in perf_event__get_comm_ids
> > > > function. It replaced left to right search for '\n' with rtrim,
> > > > which actually does right to left search. It occasionally caught
> > > > earlier '\n' and kept trash in the command name.
> > > 
> > > Sorry for my commit that have failings.
> > > 
> > > Could I know the command name in the above case ?
> > > The command name can have two '\n' ?
> > 
> > it's the next line in the status file.. parts of the Umask string
> > and 1 newline
> > 
> > Name:   systemd
> > Umask:  0000
> > State:  S (sleeping)
> > ...
> > 
> > I've already posted it in here:
> >   http://marc.info/?l=linuxppc-embedded&m=149200723316270&w=2
> > 
> > jirka
> > 
> 
> I understood it.
> Sorry for my mistake..

no worries.. we do plenty of those ;-)

jirka