Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030798AbdDTMtX (ORCPT ); Thu, 20 Apr 2017 08:49:23 -0400 Received: from mga06.intel.com ([134.134.136.31]:18645 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030246AbdDTMtT (ORCPT ); Thu, 20 Apr 2017 08:49:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,225,1488873600"; d="scan'208";a="1138098733" Subject: Re: [PATCH v8 4/6] i2c: designware: introducing I2C_SLAVE definitions To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com From: Jarkko Nikula Message-ID: Date: Thu, 20 Apr 2017 15:49:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1407 Lines: 42 On 04/12/2017 07:47 PM, Luis Oliveira wrote: > - Definitions were added to core library > - A example was added to designware-core.txt Documentation that shows > how the slave can be setup using DTS > > SLAVE related definitions were added to the core of the controller. > > Signed-off-by: Luis Oliveira > Reviewed-by: Andy Shevchenko > Acked-by: Rob Herring > Acked-by: Jarkko Nikula > --- > v7-v8 > - no changes ... > +#define DW_IC_RX_ABRT_SLAVE_RD_INTX (1UL << ABRT_SLAVE_RD_INTX) > +#define DW_IC_RX_ABRT_SLAVE_ARBLOST (1UL << ABRT_SLAVE_ARBLOST) > +#define DW_IC_RX_ABRT_SLAVE_FLUSH_TXFIFO (1UL << ABRT_SLAVE_FLUSH_TXFIFO) > > #define DW_IC_TX_ABRT_NOACK (DW_IC_TX_ABRT_7B_ADDR_NOACK | \ > DW_IC_TX_ABRT_10ADDR1_NOACK | \ > @@ -212,6 +237,7 @@ struct dw_i2c_dev { > struct completion cmd_complete; > struct clk *clk; > struct reset_control *rst; > + struct i2c_client *slave; > u32 (*get_clk_rate_khz) (struct dw_i2c_dev *dev); > struct dw_pci_controller *controller; > int cmd_err; > @@ -231,6 +257,7 @@ struct dw_i2c_dev { > struct i2c_adapter adapter; > u32 functionality; > u32 master_cfg; > + u32 slave_cfg; > unsigned int tx_fifo_depth; > unsigned int rx_fifo_depth; > int rx_outstanding; You forgot to add comments here. -- Jarkko