Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031698AbdDTNvJ (ORCPT ); Thu, 20 Apr 2017 09:51:09 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:34935 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031677AbdDTNvF (ORCPT ); Thu, 20 Apr 2017 09:51:05 -0400 Date: Thu, 20 Apr 2017 15:51:03 +0200 (CEST) From: Thomas Gleixner To: Vikas Shivappa cc: vikas.shivappa@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, sai.praneeth.prakhya@intel.com, hpa@zytor.com, mingo@kernel.org, ravi.v.shankar@intel.com, tony.luck@intel.com, fenghua.yu@intel.com Subject: Re: [PATCH 2/3] x86/intel_rdt: Trim whitespace while parsing schemata input In-Reply-To: <1492645804-17465-3-git-send-email-vikas.shivappa@linux.intel.com> Message-ID: References: <1492645804-17465-1-git-send-email-vikas.shivappa@linux.intel.com> <1492645804-17465-3-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1528 Lines: 40 On Wed, 19 Apr 2017, Vikas Shivappa wrote: > Schemata is displayed in tabular format which introduces some whitespace > to show data in a tabular format. If user wants to input the same data > that is displayed, the parsing fails. Trim the leading and trailing > whitespace to help parse such data. > > Reported-by: Prakhya, Sai Praneeth > Signed-off-by: Vikas Shivappa > Tested-by: Prakhya, Sai Praneeth > --- > arch/x86/kernel/cpu/intel_rdt_schemata.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/intel_rdt_schemata.c b/arch/x86/kernel/cpu/intel_rdt_schemata.c > index 9467a00..3cfa1ca 100644 > --- a/arch/x86/kernel/cpu/intel_rdt_schemata.c > +++ b/arch/x86/kernel/cpu/intel_rdt_schemata.c > @@ -143,7 +143,7 @@ static int parse_line(char *line, struct rdt_resource *r) > return -EINVAL; > list_for_each_entry(d, &r->domains, list) { > if (d->id == dom_id) { > - if (r->parse_ctrlval(dom, r, d)) > + if (r->parse_ctrlval(strim(dom), r, d)) > return -EINVAL; > goto next; > } > @@ -220,7 +220,7 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file *of, > goto out; > } > for_each_enabled_rdt_resource(r) { > - if (!strcmp(resname, r->name) && > + if (!strcmp(strim(resname), r->name) && Both strims() invocations are just silly. They can be done before the loop once instead of doing them over and over again. Thanks, tglx