Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032904AbdDTOoF (ORCPT ); Thu, 20 Apr 2017 10:44:05 -0400 Received: from 8bytes.org ([81.169.241.247]:38978 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032877AbdDTOnw (ORCPT ); Thu, 20 Apr 2017 10:43:52 -0400 Date: Thu, 20 Apr 2017 16:43:44 +0200 From: Joerg Roedel To: "zhichang.yuan" Cc: iommu@lists.linux-foundation.org, linuxarm@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com, zhichang.yuan02@gmail.com, yankejian@huawei.com, huangdaode@hisilicon.com Subject: Re: [PATCH] iommu: make iommu_bus_notifier return NOTIFY_DONE rather than error code Message-ID: <20170420144343.GB21305@8bytes.org> References: <1492519908-65994-1-git-send-email-yuanzhichang@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492519908-65994-1-git-send-email-yuanzhichang@hisilicon.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 546 Lines: 12 On Tue, Apr 18, 2017 at 08:51:48PM +0800, zhichang.yuan wrote: > In iommu_bus_notifier(), when action is BUS_NOTIFY_ADD_DEVICE, it will return > 'ops->add_device(dev)' directly. But ops->add_device will return ERR_VAL, such > as -ENODEV. These value will make notifier_call_chain() not to traverse the > remain nodes in struct notifier_block list. > > This patch revises iommu_bus_notifier() to return NOTIFY_DONE when some errors > heppened in ops->add_device(). > > Signed-off-by: zhichang.yuan Applied, thanks.