Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970433AbdDTPOY (ORCPT ); Thu, 20 Apr 2017 11:14:24 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:43913 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S970350AbdDTPOU (ORCPT ); Thu, 20 Apr 2017 11:14:20 -0400 Subject: Re: [PATCH] clk: ti: fix linker error with !SOC_OMAP4 To: Arnd Bergmann References: <20170419214318.1605787-1-arnd@arndb.de> <9df5f73d-3e3a-ee33-1b75-c14a1a707ad9@ti.com> CC: Michael Turquette , Stephen Boyd , Tony Lindgren , Richard Watts , , , Linux Kernel Mailing List From: Tero Kristo Message-ID: Date: Thu, 20 Apr 2017 18:13:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1697 Lines: 53 On 20/04/17 18:06, Arnd Bergmann wrote: > On Thu, Apr 20, 2017 at 4:57 PM, Tero Kristo wrote: >> On 20/04/17 00:43, Arnd Bergmann wrote: >>> >>> When none of the OMAP4-generation SoCs are enabled, we run into a link >>> error for am43xx/am43xx: >>> >>> drivers/clk/ti/dpll.o: In function `of_ti_am3_dpll_x2_setup': >>> dpll.c:(.init.text+0xd8): undefined reference to `clkhwops_omap4_dpllmx' >>> >>> This is easily fixed by adding another #ifdef. >>> >>> While looking at the code, I also spotted another problem with the >>> assignment of hw_ops variable that is not used again later. I'm >>> changing this to setting clk_hw->ops instead, which I guess is what >>> was intended here. >> >> >> Good catch... It seems the corner case is masked in the testing I did >> locally so far. >> >>> >>> Fixes: 0565fb168d63 ("clk: ti: dpll: move omap3 DPLL functionality to >>> clock driver") >> >> >> However, I believe the fixes tag should point to this one in linux-next: >> >> commit 473adbf4e02857a6b78dfb3d9fcf752638bbadb9 >> Author: Tero Kristo >> Date: Thu Feb 9 11:25:28 2017 +0200 >> >> clk: ti: dpll44xx: fix clksel register initialization > > Ah, right. > >> Other than that: >> >> Acked-by: Tero Kristo > > Do you want me to resend, or can you forward the patch with the > fixed fixes line? I guess thats up to Stephen, he typically picks single fixes like these. I can also create a pull request with the fixes you provided if Stephen prefers that, in that case I can fix the "Fixes:" tag myself. Stephen any preference? -Tero PS: I'm still checking the other two patches you provided, as they are more complex than this one.