Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970510AbdDTPW6 (ORCPT ); Thu, 20 Apr 2017 11:22:58 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38117 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S970400AbdDTPWy (ORCPT ); Thu, 20 Apr 2017 11:22:54 -0400 Subject: Re: [PATCH v2 0/3] efi: add support for non-standard capsule headers To: Jan Kiszka , Matt Fleming , Ard Biesheuvel References: Cc: linux-efi@vger.kernel.org, Linux Kernel Mailing List , Andy Shevchenko , Hock Leong Kweh , Borislav Petkov , Sascha Weisenberger From: "Bryan O'Donoghue" Message-ID: <1a10da6c-9342-c52a-71b7-669d189f17a2@nexus-software.ie> Date: Thu, 20 Apr 2017 16:27:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1532 Lines: 46 On 19/04/17 19:32, Jan Kiszka wrote: > This picks up the patches Ard send before in [1], including the > "left-over" patches 6..8. > > As Ard suggested, I've taken updated patches 6 and 7 of him from [2] > which address reviewer comments. Furthermore, I've changed patch 8 to > factor out the Quark quirk logic from the overloaded > efi_capsule_setup_info as requested by Matt and also applied Andy's > suggestion to have a quirk dispatcher table with callbacks. > > Tested successfully on the IOT2040 - still without a working Galileo > board. > > Jan > > [1] http://www.spinics.net/lists/linux-efi/msg11194.html > [2] https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=quark-capsule > > Cc: Matt Fleming > > Ard Biesheuvel (2): > efi/capsule-loader: Redirect calls to efi_capsule_setup_info via weak > alias > efi/capsule-loader: Use page addresses rather than struct page > pointers > > Jan Kiszka (1): > efi/capsule: Add support for Quark security header > > arch/x86/platform/efi/quirks.c | 137 ++++++++++++++++++++++++++++++++++ > drivers/firmware/efi/Kconfig | 9 +++ > drivers/firmware/efi/capsule-loader.c | 66 ++++++++-------- > drivers/firmware/efi/capsule.c | 7 +- > include/linux/efi.h | 14 +++- > 5 files changed, 197 insertions(+), 36 deletions(-) > Still looks good, nothing's broken on Galileo. Please feel free to add my Tested-by: Bryan O'Donoghue To your patches