Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970992AbdDTQBo (ORCPT ); Thu, 20 Apr 2017 12:01:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47278 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966707AbdDTQAT (ORCPT ); Thu, 20 Apr 2017 12:00:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8A7AE3B554 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=riel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8A7AE3B554 Message-ID: <1492704006.8850.201.camel@redhat.com> Subject: Re: [PATCH 1/2] nohz: Fix again collision between tick and other hrtimers From: Rik van Riel To: Frederic Weisbecker , Thomas Gleixner , Ingo Molnar Cc: LKML , Peter Zijlstra , James Hartsock , stable@vger.kernel.org, Tim Wright , Pavel Machek Date: Thu, 20 Apr 2017 12:00:06 -0400 In-Reply-To: <1492702230-28462-2-git-send-email-fweisbec@gmail.com> References: <1492702230-28462-1-git-send-email-fweisbec@gmail.com> <1492702230-28462-2-git-send-email-fweisbec@gmail.com> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 20 Apr 2017 16:00:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 14 On Thu, 2017-04-20 at 17:30 +0200, Frederic Weisbecker wrote: > (This restores commit 24b91e360ef521a2808771633d76ebc68bd5604b that > got > reverted by commit 558e8e27e73f53f8a512485be538b07115fe5f3c due to a > regression where CPUs spuriously stopped ticking. The issue happened > when a tick fired too early past its expected expiration: on IRQ exit > the tick was scheduled again to the same deadline but skipped > reprogramming because ts->next_tick still kept in cache the deadline. > This has been fixed now with resetting ts->next_tick from the tick > itself. Extra care has also been taken to prevent from obsolete > values > throughout CPU hotplug operations.) > Acked-by: Rik van Riel