Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033208AbdDTQLc (ORCPT ); Thu, 20 Apr 2017 12:11:32 -0400 Received: from mail.kernel.org ([198.145.29.136]:54614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033174AbdDTQLY (ORCPT ); Thu, 20 Apr 2017 12:11:24 -0400 From: Andy Lutomirski To: Jens Axboe Cc: "linux-kernel@vger.kernel.org" , Kai-Heng Feng , linux-nvme@lists.infradead.org, Christoph Hellwig , Sagi Grimberg , Keith Busch , Andy Lutomirski Subject: [PATCH v2 2/2] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA" Date: Thu, 20 Apr 2017 09:11:16 -0700 Message-Id: <69c1adef0d725e43212383b318c039f85a793b1d.1492704577.git.luto@kernel.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 32 There's a report that it malfunctions with APST on. See https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184 Cc: Kai-Heng Feng Signed-off-by: Andy Lutomirski --- drivers/nvme/host/core.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index d618b20ce6c6..1fbcdcdada78 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1395,6 +1395,15 @@ struct nvme_core_quirk_entry { }; static const struct nvme_core_quirk_entry core_quirks[] = { + { + /* + * This Toshiba device seems to die using any APST states. See: + * https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184/comments/11 + */ + .vid = 0x1179, + .mn = "THNSF5256GPUK TOSHIBA", + .quirks = NVME_QUIRK_NO_APST, + } }; /* match is null-terminated but idstr is space-padded. */ -- 2.9.3