Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S971109AbdDTQTo (ORCPT ); Thu, 20 Apr 2017 12:19:44 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36394 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S971027AbdDTQT3 (ORCPT ); Thu, 20 Apr 2017 12:19:29 -0400 Subject: Re: [PATCH 4/4] nvme/pci: switch to pci_request_irq To: Keith Busch , Christoph Hellwig References: <20170413070643.32165-1-hch@lst.de> <20170413070643.32165-5-hch@lst.de> <20170413200255.GB22775@localhost.localdomain> Cc: Bjorn Helgaas , "linux-pci@vger.kernel.org" , Thomas Gleixner , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" From: Sagi Grimberg Message-ID: Date: Thu, 20 Apr 2017 19:19:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170413200255.GB22775@localhost.localdomain> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 271 Lines: 10 > This is great. As an added bonus, more of struct nvme_queue's hot values > are in the same cache line! > > Reviewed-by: Keith Busch I think I can kill off for mlx5 as well. Very useful Christoph! Reviewed-by: Sagi Grimberg