Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945782AbdDTRL2 (ORCPT ); Thu, 20 Apr 2017 13:11:28 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:34588 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S971442AbdDTRLX (ORCPT ); Thu, 20 Apr 2017 13:11:23 -0400 Subject: Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop() To: Alexander Kochetkov , "David S. Miller" , Philippe Reynes , Peter Chen , Wei Yongjun , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1492694974-31023-1-git-send-email-al.kochet@gmail.com> From: Florian Fainelli Message-ID: <19bf7cd3-e83c-62bf-3b01-f574811a9e65@gmail.com> Date: Thu, 20 Apr 2017 10:11:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1492694974-31023-1-git-send-email-al.kochet@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 15 On 04/20/2017 06:29 AM, Alexander Kochetkov wrote: > Currently driver use phy_start_aneg() in arc_emac_open() to bring > up PHY. But phy_start() function is more appropriate for this purposes. > Besides that it call phy_start_aneg() as part of PHY startup sequence > it also can correctly bring up PHY from error and suspended states. > So the patch replace phy_start_aneg() to phy_start(). > > Also the patch add call to phy_stop() to arc_emac_stop() to allow > the PHY device to be fully suspended when the interface is unused. > > Signed-off-by: Alexander Kochetkov Reviewed-by: Florian Fainelli -- Florian