Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S946809AbdDTSsi (ORCPT ); Thu, 20 Apr 2017 14:48:38 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:36565 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S946794AbdDTSsf (ORCPT ); Thu, 20 Apr 2017 14:48:35 -0400 From: Myungho Jung To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org Subject: [PATCH v2] timer/sysclt: Restrict timer migration sysctl values to 0 and 1 Date: Thu, 20 Apr 2017 11:48:33 -0700 Message-Id: <1492714113-9707-1-git-send-email-mhjungk@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1237 Lines: 45 timer_migration sysctl acts as a boolean switch, so the allowed values should be restricted to 0 and 1. Add the necessary extra fields to the sysctl table entry to enforce that. Testcase is ltp/runpwtests06. Signed-off-by: Myungho Jung --- Changes in v2: - Correct commit log kernel/sysctl.c | 2 ++ kernel/time/timer.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 8c8714f..21343d1 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -1176,6 +1176,8 @@ static struct ctl_table kern_table[] = { .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = timer_migration_handler, + .extra1 = &zero, + .extra2 = &one, }, #endif #ifdef CONFIG_BPF_SYSCALL diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 1dc0256..cc6b6bd 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -241,7 +241,7 @@ int timer_migration_handler(struct ctl_table *table, int write, int ret; mutex_lock(&mutex); - ret = proc_dointvec(table, write, buffer, lenp, ppos); + ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos); if (!ret && write) timers_update_migration(false); mutex_unlock(&mutex); -- 2.7.4