Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031969AbdDTS4p convert rfc822-to-8bit (ORCPT ); Thu, 20 Apr 2017 14:56:45 -0400 Received: from mail.kernel.org ([198.145.29.136]:51204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031712AbdDTS4l (ORCPT ); Thu, 20 Apr 2017 14:56:41 -0400 MIME-Version: 1.0 In-Reply-To: References: <9cd43193-af6b-2cb1-3951-5fa569bf1f31@kernel.dk> <20170420162925.GB25259@localhost.localdomain> <90f94a38-7508-ba80-aa14-827e758dd418@kernel.dk> <2a988a17-eb37-58ca-edd7-a11d4bb61f5a@kernel.dk> From: Andy Lutomirski Date: Thu, 20 Apr 2017 11:56:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/2] nvme APST quirk updates, take two To: Jens Axboe Cc: linux-nvme , Keith Busch , Kai-Heng Feng , Christoph Hellwig , "linux-kernel@vger.kernel.org" , Sagi Grimberg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2483 Lines: 58 On Thu, Apr 20, 2017 at 10:08 AM, Jens Axboe wrote: > On 04/20/2017 11:06 AM, Andy Lutomirski wrote: >> >> >> On Apr 20, 2017 9:38 AM, "Jens Axboe" > wrote: >> >> On 04/20/2017 10:30 AM, Jens Axboe wrote: >> > On 04/20/2017 10:29 AM, Keith Busch wrote: >> >> On Thu, Apr 20, 2017 at 07:15:15PM +0300, Sagi Grimberg wrote: >> >>> >> >>>>> Hi Jens- >> >>>>> >> >>>>> These are just the quirk updates, split out. The patches are >> >>>>> unchanged. >> >>>>> >> >>>>> I think that, even if we want to apply a broader quirk for 4.11, we >> >>>>> should still apply these so that we can cleanly revert the broader >> >>>>> quirk later. IOW, let's get the known regressions fixed before we >> >>>>> get too excited about the unknown regressions. >> >>>> >> >>>> This looks good to me, and 4.11 appropriate. I'll expedite this >> >>>> through the block tree, if Keith/Sagi/Christoph agrees on this >> >>>> being the right approach for 4.11. >> >>> >> >>> I'm perfectly fine with this going to 4.11 >> >> >> >> All good with me as well. >> >> >> >> Reviewed-by: Keith Busch > >> > >> > Great, I have queued it up. >> >> Spoke too soon. Andy, did you compile this? >> >> drivers/nvme/host/core.c: In function ‘nvme_init_identify’: >> drivers/nvme/host/core.c:1524:6: error: ‘force_apst’ undeclared (first use in this function) >> if (force_apst && (ctrl->quirks & NVME_QUIRK_NO_DEEPEST_PS)) { >> ^~~~~~~~~~ >> drivers/nvme/host/core.c:1524:6: note: each undeclared identifier is reported only once for each function it appears in >> >> No, you did not. >> >> >> I compiled the end result but not the middle. D'oh. Better version coming in an hour or two. > > This is from the end-result. I think you compiled the previous series, > but not the revised v2 one you sent out. Because none of those patches > add force_apst. I was differently dumb. I did git rebase -i and rearranged everything, but I did git rebase --continue before running make, so I tested the buggy patch with the patch that added force_apst on top. Anyway, this time I'm going to compile, boot, and play with the exact patches I send before I send them. (Sadly, removing the debug patch from the series has made this type of testing harder. Oh well.) --Andy