Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S947286AbdDTTtE (ORCPT ); Thu, 20 Apr 2017 15:49:04 -0400 Received: from anholt.net ([50.246.234.109]:36510 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S947201AbdDTTtB (ORCPT ); Thu, 20 Apr 2017 15:49:01 -0400 From: Eric Anholt To: Russell King - ARM Linux Cc: dri-devel@lists.freedesktop.org, tom.cooksey@arm.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] drm/pl111: Initial drm/kms driver for pl111 In-Reply-To: <20170412225125.GC17774@n2100.armlinux.org.uk> References: <20170411011801.15788-1-eric@anholt.net> <20170411093737.GV17774@n2100.armlinux.org.uk> <8737df0vzs.fsf@eliezer.anholt.net> <20170411181021.GW17774@n2100.armlinux.org.uk> <87shleek2i.fsf@eliezer.anholt.net> <20170412225125.GC17774@n2100.armlinux.org.uk> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 20 Apr 2017 12:48:58 -0700 Message-ID: <87zifa7tcl.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2311 Lines: 61 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Russell King - ARM Linux writes: > On Tue, Apr 11, 2017 at 02:00:21PM -0700, Eric Anholt wrote: >> Russell King - ARM Linux writes: >>=20 >> > On Tue, Apr 11, 2017 at 09:06:31AM -0700, Eric Anholt wrote: >> >> Russell King - ARM Linux writes: >> >>=20 >> >> > On Mon, Apr 10, 2017 at 06:18:01PM -0700, Eric Anholt wrote: >> >> >> v5: Move register definitions inside the driver directory, fix bui= ld >> >> >> in COMPILE_TEST and !AMBA mode. >> >> > >> >> > Why is it necessary to move the register definitions there, when >> >> > they're already available in linux/amba/clcd.h and are required >> >> > for the FB driver? >> >> > >> >> > It is absurd to have driver specific register definitions. >> >>=20 >> >> Because after v2, v3, and v4, I still didn't have an ack on the patch= to >> >> move the register definitions from linux/amba/clcd.h to >> >> linux/amba/clcd-reg.h. If you'd like to go back and ack that, I'd re= use >> >> them. >> > >> > I don't remember seeing such a patch, sorry. >>=20 >> https://patchwork.kernel.org/patch/9654991/ > > Looks fine, apart from the missing #ifndef...#endif guard around the > header file. Are you good with the current version with the ifdef guards? I'd like to merge it through drm-misc. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlj5EKoACgkQtdYpNtH8 nuj40Q/+LSBH5SK99w8jeTj85F8RX1jgQYBrougS8m/HczZnMeX7md7SROz+0wia /3zPMAIwr5XtW2CCsUSbNP/HiuzN6UNZQ+1ZOV2CGIC9iRvgeq/FsH67wVgT+k21 iOuJ7FAwU3auGemjtMLoGtrKQdfXV5K3ZUPqnP2moKYoZcWliwR7ed65tvia5rbw ftzsUuXdngBgB1HjIAj7MJrkBZgZlac9WrcSN7ADpk71Aago/KeKYfgpwucmB1ly OseAaLVTBBLW6q7i3WOFSo7Tz6Bch/7JySN4g+BkurqAsAh38/e7yrHTHSedtsTY nVZHlOY84GL1vNFlC+5/9ZOi/dnvPJFqd+xIuozG/CBqK/1lZrg+f9x2GKEVEj0r J7N1B172Ws90FuHfK0dTNu0C3V4hBxruTwytLiem74/s1AWXla6HSlWNKm8tvf2d Mwbcf0zs6/WfFRG7hssjWoPq1hFZTnwGpz5QlOfOisUfy9QSIWvVm1vOfWOIlXTn YAXN46BM2EkwgFnHlWK8mjSl4LMPp+vBZsHAROejpd2w4PrQX0GCFhh2uOrd7km3 zxvADRxmfklWT9XEvGdW9p1KEHg/bszL+fF2aoCGTwfCZh/jZyJKq7+K6z3Qk99a ca/z7abA4Ykfu1rUSj86VHA+MwRevtg7+xrRKEXv0MekfV5x95A= =sB/A -----END PGP SIGNATURE----- --=-=-=--