Date: Thu, 20 Apr 2017 15:09:14 -0600
From: Jonathan Corbet <corbet@lwn.net>
To: Li Qiang <liq3ea@gmail.com>
Cc: jason.wessel@windriver.com, labbott@redhat.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        kgdb-bugreport@lists.sourceforge.net, Li Qiang <liqiang6-s@360.cn>
Subject: Re: [PATCH] Documentation: DocBook: kgdb: update
 CONFIG_STRICT_KERNEL_RWX info
Message-ID: <20170420150914.18399eb8@lwn.net>
In-Reply-To: <1492567125-61756-1-git-send-email-liqiang6-s@360.cn>
References: <1492567125-61756-1-git-send-email-liqiang6-s@360.cn>
Organization: LWN.net
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1191
Lines: 32

On Tue, 18 Apr 2017 18:58:45 -0700
Li Qiang <liq3ea@gmail.com> wrote:

> CONFIG_STRICT_KERNEL_RWX is no longer selectable on most architectures.
> Update this info to the documentation.
> 
> Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> ---
>  Documentation/DocBook/kgdb.tmpl | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/DocBook/kgdb.tmpl b/Documentation/DocBook/kgdb.tmpl
> index 856ac20..ef0b67b 100644
> --- a/Documentation/DocBook/kgdb.tmpl
> +++ b/Documentation/DocBook/kgdb.tmpl
> @@ -121,7 +121,9 @@
>      If kgdb supports it for the architecture you are using, you can
>      use hardware breakpoints if you desire to run with the
>      CONFIG_STRICT_KERNEL_RWX option turned on, else you need to turn off
> -    this option.
> +    this option. In most architectures, this option is not selectable.
> +    For this situation, it can be turned off by adding a runtime parameter
> +    'rodata=off'.

So this is an improvement, I guess, though the paragraph remains kind of
confusing.  Is there any chance we could actually just say which
architectures can use hardware breakpoints, and which should boot with
rodata=off?

Thanks,

jon