Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S948243AbdDUAEI (ORCPT ); Thu, 20 Apr 2017 20:04:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35764 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S947712AbdDUAEG (ORCPT ); Thu, 20 Apr 2017 20:04:06 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4D1C460FF6 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v2] PCI: disable SERR for kdump kernel To: Yinghai Lu References: <20170419003130.5302-1-yinghai@kernel.org> <584359f9-5851-08c8-4b80-ae73abc4fe59@codeaurora.org> Cc: Bjorn Helgaas , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List From: Sinan Kaya Message-ID: Date: Thu, 20 Apr 2017 20:04:03 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1160 Lines: 35 On 4/20/2017 7:37 PM, Yinghai Lu wrote: > On Thu, Apr 20, 2017 at 10:14 AM, Sinan Kaya wrote: >> On 4/18/2017 8:31 PM, Yinghai Lu wrote: >>> * pci_setup_device - fill in class and map information of a device >>> * @dev: the device structure to fill >>> @@ -1572,6 +1592,9 @@ int pci_setup_device(struct pci_dev *dev >>> /* device class may be changed after fixup */ >>> class = dev->class >> 8; >>> >>> + if (is_kdump_kernel()) >>> + pci_disable_serr(dev); >>> + >> >> This sounds like something that needs to be done while shutting down >> the first kernel as part of the kdump procedure rather than boot of >> the kdump kernel in pci setup. > > For kdump path, first kernel shutdown path is not called. > > We have to do sth in second kernel instead. > I didn't know that. Bjorn's compatibility point is also a concern. Ideally you want something in both places. > Thanks > > Yinghai > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.