Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034537AbdDUCDO (ORCPT ); Thu, 20 Apr 2017 22:03:14 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34271 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034488AbdDUCDM (ORCPT ); Thu, 20 Apr 2017 22:03:12 -0400 Subject: Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support To: Stefan Agner , dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, richard@nod.at, cyrille.pitchen@atmel.com References: <20170421010755.18025-1-stefan@agner.ch> <20170421010755.18025-3-stefan@agner.ch> Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, kernel@pengutronix.de, han.xu@nxp.com, fabio.estevam@freescale.com, LW@KARO-electronics.de, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: Date: Fri, 21 Apr 2017 04:03:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170421010755.18025-3-stefan@agner.ch> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1740 Lines: 54 On 04/21/2017 03:07 AM, Stefan Agner wrote: > Add support for i.MX 7 SoC. The i.MX 7 has a slightly different > clock architecture requiring only two clocks to be referenced. > The IP is slightly different compared to i.MX 6SoloX, but currently > none of this differences are in use so there is no detection needed > and the driver can reuse IS_MX6SX. > > Signed-off-by: Stefan Agner > --- > drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > index c8bbf5da2ab8..4a45d37ddc80 100644 > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > @@ -127,6 +127,18 @@ static const struct gpmi_devdata gpmi_devdata_imx6sx = { > .clks_count = ARRAY_SIZE(gpmi_clks_for_mx6), > }; > > +static const char * const gpmi_clks_for_mx7d[] = { > + "gpmi_io", "gpmi_bch_apb", > +}; > + > +static const struct gpmi_devdata gpmi_devdata_imx7d = { > + .type = IS_MX6SX, Would it make sense to use IS_MX7 here already to prevent future surprises ? > + .bch_max_ecc_strength = 62, > + .max_chain_delay = 12, > + .clks = gpmi_clks_for_mx7d, > + .clks_count = ARRAY_SIZE(gpmi_clks_for_mx7d), > +}; > + > static irqreturn_t bch_irq(int irq, void *cookie) > { > struct gpmi_nand_data *this = cookie; > @@ -2071,6 +2083,9 @@ static const struct of_device_id gpmi_nand_id_table[] = { > }, { > .compatible = "fsl,imx6sx-gpmi-nand", > .data = &gpmi_devdata_imx6sx, > + }, { > + .compatible = "fsl,imx7d-gpmi-nand", > + .data = &gpmi_devdata_imx7d, > }, {} > }; > MODULE_DEVICE_TABLE(of, gpmi_nand_id_table); > -- Best regards, Marek Vasut