Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034497AbdDUCEX (ORCPT ); Thu, 20 Apr 2017 22:04:23 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36529 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034337AbdDUCET (ORCPT ); Thu, 20 Apr 2017 22:04:19 -0400 Subject: Re: [PATCH 1/5] mtd: nand: gpmi: unify clock handling To: Stefan Agner , dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, richard@nod.at, cyrille.pitchen@atmel.com References: <20170421010755.18025-1-stefan@agner.ch> <20170421010755.18025-2-stefan@agner.ch> Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, kernel@pengutronix.de, han.xu@nxp.com, fabio.estevam@freescale.com, LW@KARO-electronics.de, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: <66b18c07-54f1-a532-5fce-e1759c5d3488@gmail.com> Date: Fri, 21 Apr 2017 04:02:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170421010755.18025-2-stefan@agner.ch> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 794 Lines: 27 On 04/21/2017 03:07 AM, Stefan Agner wrote: > Add device specific list of clocks required, and handle all clocks > in a single for loop. This avoids further code duplication when > adding i.MX 7 support. > > Signed-off-by: Stefan Agner [...] > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.h b/drivers/mtd/nand/gpmi-nand/gpmi-nand.h > index 4e49a1f5fa27..2e584e18d980 100644 > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.h > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.h > @@ -130,6 +130,8 @@ struct gpmi_devdata { > enum gpmi_type type; > int bch_max_ecc_strength; > int max_chain_delay; /* See the async EDO mode */ > + const char * const *clks; > + int clks_count; const int ? :) Reviewed-by: Marek Vasut -- Best regards, Marek Vasut