Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035542AbdDUFX2 (ORCPT ); Fri, 21 Apr 2017 01:23:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55476 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1035210AbdDUFX0 (ORCPT ); Fri, 21 Apr 2017 01:23:26 -0400 Date: Fri, 21 Apr 2017 07:23:14 +0200 From: Greg KH To: Andriy Gelman Cc: wsa@the-dreams.de, bhumirks@gmail.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] Added paranthesis around complex define statements Message-ID: <20170421052314.GA30975@kroah.com> References: <1492751746-8418-1-git-send-email-andriy.gelman@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492751746-8418-1-git-send-email-andriy.gelman@gmail.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 935 Lines: 34 On Fri, Apr 21, 2017 at 05:15:46AM +0000, Andriy Gelman wrote: > This is a patch to the ks_wlan_ioctl.h file that fixes paranthesis error > found by the checkpatch.pl tool No, it also does other things :( Also, please fix up the subject to look like other patches done for this file/driver. And fix the spelling mistake :) > > Signed-off-by: Andriy Gelman > --- > drivers/staging/ks7010/ks_wlan_ioctl.h | 53 +++++++++++++++++----------------- > 1 file changed, 26 insertions(+), 27 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h > index 8e62b10..851f563 100644 > --- a/drivers/staging/ks7010/ks_wlan_ioctl.h > +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h > @@ -1,6 +1,6 @@ > /* > * Driver for KeyStream 11b/g wireless LAN > - * > + * This is not a () change :( Please only do one type of thing in each patch. thanks, greg k-h