Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035572AbdDUF1D (ORCPT ); Fri, 21 Apr 2017 01:27:03 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:40315 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1035268AbdDUF1A (ORCPT ); Fri, 21 Apr 2017 01:27:00 -0400 Subject: Re: [PATCH net-next v3] bindings: net: stmmac: add missing note about LPI interrupt To: Niklas Cassel , Rob Herring , Mark Rutland , "David S. Miller" , Joao Pinto , Niklas Cassel , Alexandre TORGUE , Thierry Reding , Eric Engestrom References: <20170418123955.21335-1-niklass@axis.com> CC: , , From: Giuseppe CAVALLARO Message-ID: <8d41bee9-9564-ef47-ba58-7becb97ab672@st.com> Date: Fri, 21 Apr 2017 07:26:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170418123955.21335-1-niklass@axis.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG7NODE1.st.com (10.75.127.19) To SFHDAG4NODE1.st.com (10.75.127.10) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-21_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2242 Lines: 47 On 4/18/2017 2:39 PM, Niklas Cassel wrote: > From: Niklas Cassel > > The hardware has a LPI interrupt. > There is already code in the stmmac driver to parse and handle the > interrupt. However, this information was missing from the DT binding. > > At the same time, improve the description of the existing interrupts. > > Signed-off-by: Niklas Cassel > --- > Documentation/devicetree/bindings/net/stmmac.txt | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt > index f652b0c384ce..c3a7be6615c5 100644 > --- a/Documentation/devicetree/bindings/net/stmmac.txt > +++ b/Documentation/devicetree/bindings/net/stmmac.txt > @@ -7,9 +7,12 @@ Required properties: > - interrupt-parent: Should be the phandle for the interrupt controller > that services interrupts for this device > - interrupts: Should contain the STMMAC interrupts > -- interrupt-names: Should contain the interrupt names "macirq" > - "eth_wake_irq" if this interrupt is supported in the "interrupts" > - property > +- interrupt-names: Should contain a list of interrupt names corresponding to > + the interrupts in the interrupts property, if available. > + Valid interrupt names are: > + - "macirq" (combined signal for various interrupt events) > + - "eth_wake_irq" (the interrupt to manage the remote wake-up packet detection) > + - "eth_lpi" (the interrupt that occurs when Tx or Rx enters/exits LPI state) > - phy-mode: See ethernet.txt file in the same directory. > - snps,reset-gpio gpio number for phy reset. > - snps,reset-active-low boolean flag to indicate if phy reset is active low. > @@ -152,8 +155,8 @@ Examples: > compatible = "st,spear600-gmac"; > reg = <0xe0800000 0x8000>; > interrupt-parent = <&vic1>; > - interrupts = <24 23>; > - interrupt-names = "macirq", "eth_wake_irq"; > + interrupts = <24 23 22>; > + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; > mac-address = [000000000000]; /* Filled in by U-Boot */ > max-frame-size = <3800>; > phy-mode = "gmii"; Acked-by: Giuseppe Cavallaro