Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035983AbdDUHTQ (ORCPT ); Fri, 21 Apr 2017 03:19:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55808 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1035764AbdDUHTO (ORCPT ); Fri, 21 Apr 2017 03:19:14 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 79BED9E635 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 79BED9E635 Subject: Re: [PATCH] platform/x86: INT33FE: add i2c dependency To: Tobias Regnery , dvhart@infradead.org, andy@infradead.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170420125159.23846-1-tobias.regnery@gmail.com> From: Hans de Goede Message-ID: <62aa9baa-6630-2f09-96a7-3328af823db6@redhat.com> Date: Fri, 21 Apr 2017 09:19:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <20170420125159.23846-1-tobias.regnery@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 21 Apr 2017 07:19:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2154 Lines: 53 Hi, On 20-04-17 14:51, Tobias Regnery wrote: > With CONFIG_I2C=m and CONFIG_INTEL_CHT_INT33FE=y we see the following link > errors: > > drivers/built-in.o: In function 'cht_int33fe_remove': > intel_cht_int33fe.c:(.text+0x391f6e): undefined reference to 'i2c_unregister_device' > intel_cht_int33fe.c:(.text+0x391f76): undefined reference to 'i2c_unregister_device' > intel_cht_int33fe.c:(.text+0x391f7d): undefined reference to 'i2c_unregister_device' > drivers/built-in.o: In function 'cht_int33fe_probe': > intel_cht_int33fe.c:(.text+0x392147): undefined reference to 'i2c_acpi_new_device' > intel_cht_int33fe.c:(.text+0x392185): undefined reference to 'i2c_acpi_new_device' > intel_cht_int33fe.c:(.text+0x3921bd): undefined reference to 'i2c_acpi_new_device' > intel_cht_int33fe.c:(.text+0x3921d9): undefined reference to 'i2c_unregister_device' > intel_cht_int33fe.c:(.text+0x3921e8): undefined reference to 'i2c_unregister_device' > drivers/built-in.o: In function 'cht_int33fe_driver_init': > intel_cht_int33fe.c:(.init.text+0x2386d): undefined reference to 'i2c_register_driver' > drivers/built-in.o: In function 'cht_int33fe_driver_exit': > intel_cht_int33fe.c:(.exit.text+0x206e): undefined reference to 'i2c_del_driver' > > Fix this by adding a kconfig dependency on the I2C subsystem. > > Fixes: 1cd706df8a9c ("platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver") > Signed-off-by: Tobias Regnery Thank you for catching this: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 6b33db6c9d22..ea264fefb845 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -783,7 +783,7 @@ config ACPI_CMPC > > config INTEL_CHT_INT33FE > tristate "Intel Cherry Trail ACPI INT33FE Driver" > - depends on X86 && ACPI > + depends on X86 && ACPI && I2C > ---help--- > This driver add support for the INT33FE ACPI device found on > some Intel Cherry Trail devices. >