Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1036132AbdDUHkd (ORCPT <rfc822;w@1wt.eu>);
        Fri, 21 Apr 2017 03:40:33 -0400
Received: from mail-io0-f195.google.com ([209.85.223.195]:33401 "EHLO
        mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932092AbdDUHkb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 21 Apr 2017 03:40:31 -0400
Date: Fri, 21 Apr 2017 00:40:25 -0700 (PDT)
From: Chandra Annamaneni <chandra627@gmail.com>
X-X-Sender: chandra@panther
To: chandrasekhar annamaneni <chandra627@gmail.com>
cc: christian.gromm@microchip.com, andrey.shvetsov@k2l.de,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: most: use __func__ instead of the function
 name
In-Reply-To: <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1704210039130.21893@panther>
References: <alpine.DEB.2.20.1703171242310.3207@turtle> <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-2116409239-1492760430=:21893"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3550
Lines: 103

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-2116409239-1492760430=:21893
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT


Third Reminder. Please review.

--
Chandra


On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote:

> 
> Second reminder, please review.
> 
> Thanks.
> Chandra
> 
> 
> On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@gmail.com>
> wrote:
> 
>       Change video.c to use %s, __func__ instead of function names.
>       Warnings flagged by checkpatch.pl
> 
>       Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
> 
>       diff --git a/drivers/staging/most/aim-v4l2/video.c
>       b/drivers/staging/most/aim-v4l2/video.c
>       index e074841..59e861e 100644
>       --- a/drivers/staging/most/aim-v4l2/video.c
>       +++ b/drivers/staging/most/aim-v4l2/video.c
>       @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
>               struct most_video_dev *mdev = video_drvdata(filp);
>               struct aim_fh *fh;
> 
>       -       v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
>       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>               switch (vdev->vfl_type) {
>               case VFL_TYPE_GRABBER:
>       @@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp)
>               struct most_video_dev *mdev = fh->mdev;
>               struct mbo *mbo, *tmp;
> 
>       -       v4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n");
>       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>               /*
>                * We need to put MBOs back before we call
>       most_stop_channel()
>       @@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file,
>       void *priv, v4l2_std_id *norm)
>               struct aim_fh *fh = priv;
>               struct most_video_dev *mdev = fh->mdev;
> 
>       -       v4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n");
>       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>               *norm = V4L2_STD_UNKNOWN;
>               return 0;
>       @@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file,
>       void *priv, unsigned int index)
>               struct aim_fh *fh = priv;
>               struct most_video_dev *mdev = fh->mdev;
> 
>       -       v4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n",
>       index);
>       +       v4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index);
> 
>               if (index >= V4L2_AIM_MAX_INPUT)
>                       return -EINVAL;
>       @@ -441,7 +441,7 @@ static int aim_register_videodev(struct
>       most_video_dev *mdev)
>        {
>               int ret;
> 
>       -       v4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n");
>       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>               init_waitqueue_head(&mdev->wait_data);
> 
>       @@ -471,7 +471,7 @@ static int aim_register_videodev(struct
>       most_video_dev *mdev)
> 
>        static void aim_unregister_videodev(struct most_video_dev
>       *mdev)
>        {
>       -       v4l2_info(&mdev->v4l2_dev,
>       "aim_unregister_videodev()\n");
>       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>               video_unregister_device(mdev->vdev);
>        }
> 
> 
> 
> 
--8323329-2116409239-1492760430=:21893--