Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1036493AbdDUIGO (ORCPT ); Fri, 21 Apr 2017 04:06:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:60662 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1036396AbdDUIFG (ORCPT ); Fri, 21 Apr 2017 04:05:06 -0400 X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" From: Johannes Thumshirn To: "Martin K . Petersen" Cc: James Bottomley , Christoph Hellwig , Hannes Reinecke , Bart Van Assche , Linux SCSI Mailinglist , Linux Kernel Mailinglist , Jinpu Wang , John Garry , tj@kernel.org, Johannes Thumshirn Subject: [PATCH v2 2/5] aic94xx: remove the SAS host after the SCSI host Date: Fri, 21 Apr 2017 10:04:47 +0200 Message-Id: <6662a9f80f6bc52dd0e28cf57d9612c3bef2fd4f.1492760075.git.jthumshirn@suse.de> X-Mailer: git-send-email 2.12.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 35 After commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive") changed the removal path of kernfs to make it recursive we have to remove the SAS host before the SCSI host or we will see sysfs warnings on not found sysfs groups for kobjects. Signed-off-by: Johannes Thumshirn Reviewed-by: Hannes Reinecke --- drivers/scsi/aic94xx/aic94xx_init.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c index 662b2321d1b0..8b9c6b9ea67d 100644 --- a/drivers/scsi/aic94xx/aic94xx_init.c +++ b/drivers/scsi/aic94xx/aic94xx_init.c @@ -701,13 +701,14 @@ static int asd_register_sas_ha(struct asd_ha_struct *asd_ha) static int asd_unregister_sas_ha(struct asd_ha_struct *asd_ha) { + struct Scsi_Host *shost = asd_ha->sas_ha.core.shost; int err; - scsi_remove_host(asd_ha->sas_ha.core.shost); err = sas_unregister_ha(&asd_ha->sas_ha); - sas_remove_host(asd_ha->sas_ha.core.shost); - scsi_host_put(asd_ha->sas_ha.core.shost); + sas_remove_host(shost); + scsi_remove_host(shost); + scsi_host_put(shost); kfree(asd_ha->sas_ha.sas_phy); kfree(asd_ha->sas_ha.sas_port); -- 2.12.0