Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1036927AbdDUIjs (ORCPT ); Fri, 21 Apr 2017 04:39:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:37072 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S947422AbdDUIjm (ORCPT ); Fri, 21 Apr 2017 04:39:42 -0400 Date: Fri, 21 Apr 2017 10:39:38 +0200 From: Johannes Thumshirn To: John Garry Cc: "Martin K . Petersen" , James Bottomley , Christoph Hellwig , Hannes Reinecke , Bart Van Assche , Linux SCSI Mailinglist , Linux Kernel Mailinglist , Jinpu Wang , tj@kernel.org, wangyijing@huawei.com, Heyousong , "chenqilin (C)" , Linuxarm Subject: Re: [PATCH v2 0/5] Re-order scsi_remove_host and sas_remove_host in SAS HBA LLDDs Message-ID: <20170421083938.GD26346@linux-x5ow.site> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1923 Lines: 42 On Fri, Apr 21, 2017 at 09:34:18AM +0100, John Garry wrote: > Thanks Johannes. > > @wangyijing, can you test this patchset please (specifically 3/5)? I know > that you have the modified version of libsas which you dabbled with > upstreaming. > > On 21/04/2017 09:04, Johannes Thumshirn wrote: > >This series re-orders the calls to scsi_remove_host() and sas_remove_host() in > >all SAS HBA drivers (apart from mpt3sas which is doing it correctly). This is > >for two reasons: > > 1) After the change to recursive removal of sysfs entries, we're > > trying to remove already removed kobjects when doing a > > sas_remove_host() _after_ a scsi_remove_host() > > 2) the documentation mandates it even (becuase of 1) > > > >Unfortunately this does not completely solve issues with recursive sysfs > >removals in SAS, as libsas has asynchronous behaviour where strong ordering > >would be needed. But I am working on it and I do know other do as well. So if > >anyone else (James, Christoph, Bart, I'm looking at you) has an idea, I do > >have test setups and I'm willing to take input in form of ideas and patches. > > > > wangyijing already sent an RFC for fixing this issue (mentioned above), > which was a signifiagnt rewrite of some of libsas. > I am hoping that he would retry, and that community would support/shepherd > this activity, or at least say it will be accepted so effort is not wasted. Do you have a link to the series? No problem if not, I'll probably can find it in my archives. Anyways, if Wangyijing is re-sending his patches please Cc me on it. Thanks, Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850