Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1037063AbdDUIun (ORCPT ); Fri, 21 Apr 2017 04:50:43 -0400 Received: from conssluserg-01.nifty.com ([210.131.2.80]:39241 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1036189AbdDUIul (ORCPT ); Fri, 21 Apr 2017 04:50:41 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com v3L8oGvX025186 X-Nifty-SrcIP: [209.85.161.170] MIME-Version: 1.0 In-Reply-To: <4121ae55-b126-0a3e-b1a8-4cef5c39f5d4@samsung.com> References: <1492682232-29769-1-git-send-email-yamada.masahiro@socionext.com> <1492682232-29769-6-git-send-email-yamada.masahiro@socionext.com> <4121ae55-b126-0a3e-b1a8-4cef5c39f5d4@samsung.com> From: Masahiro Yamada Date: Fri, 21 Apr 2017 17:50:15 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/28] drm/bridge: fix include notation and remove -Iinclude/drm flag To: Andrzej Hajda Cc: dri-devel , David Airlie , Daniel Vetter , Jani Nikula , Sean Paul , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2569 Lines: 82 2017-04-21 14:51 GMT+09:00 Andrzej Hajda : > Hi Masahiro, > > On 20.04.2017 11:56, Masahiro Yamada wrote: >> Include instead of relative path from include/drm, then >> remove the -Iinclude/drm compiler flag. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> drivers/gpu/drm/bridge/Makefile | 2 -- >> drivers/gpu/drm/bridge/nxp-ptn3460.c | 10 +++++----- >> drivers/gpu/drm/bridge/parade-ps8622.c | 8 ++++---- >> 3 files changed, 9 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile >> index 3fe2226..defcf1e 100644 >> --- a/drivers/gpu/drm/bridge/Makefile >> +++ b/drivers/gpu/drm/bridge/Makefile >> @@ -1,5 +1,3 @@ >> -ccflags-y := -Iinclude/drm >> - >> obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o >> obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o >> obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o >> diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c >> index 3517043..3fc285a 100644 >> --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c >> +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c >> @@ -24,11 +24,11 @@ >> #include >> #include >> >> -#include "drm_crtc.h" >> -#include "drm_crtc_helper.h" >> -#include "drm_atomic_helper.h" >> -#include "drm_edid.h" >> -#include "drmP.h" >> +#include >> +#include >> +#include >> +#include >> +#include > > Could you merge these includes with the ones above and sort them > alphabetically. > >> >> #define PTN3460_EDID_ADDR 0x0 >> #define PTN3460_EDID_EMULATION_ADDR 0x84 >> diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c >> index 1dcec3b..ada2186 100644 >> --- a/drivers/gpu/drm/bridge/parade-ps8622.c >> +++ b/drivers/gpu/drm/bridge/parade-ps8622.c >> @@ -28,10 +28,10 @@ >> #include >> #include >> >> -#include "drmP.h" >> -#include "drm_crtc.h" >> -#include "drm_crtc_helper.h" >> -#include "drm_atomic_helper.h" >> +#include >> +#include >> +#include >> +#include > > Ditto. > > After this change you can add my: > Reviewed-by: Andrzej Hajda > OK, I will wait for the maintainers' comments about whether I need do this sort for whole of the series. -- Best Regards Masahiro Yamada