Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1037241AbdDUJAm (ORCPT <rfc822;w@1wt.eu>);
        Fri, 21 Apr 2017 05:00:42 -0400
Received: from mail.netline.ch ([148.251.143.178]:49206 "EHLO
        netline-mail3.netline.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755249AbdDUJAk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 21 Apr 2017 05:00:40 -0400
Subject: Re: [PATCH 01/28] drm/ttm: fix include notation and remove
 -Iinclude/drm flag
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Sean Paul <seanpaul@chromium.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <1492682232-29769-1-git-send-email-yamada.masahiro@socionext.com>
 <1492682232-29769-2-git-send-email-yamada.masahiro@socionext.com>
From: =?UTF-8?Q?Michel_D=c3=a4nzer?= <michel@daenzer.net>
Message-ID: <840b18a4-beae-0b56-f518-885572b24608@daenzer.net>
Date: Fri, 21 Apr 2017 18:00:19 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1492682232-29769-2-git-send-email-yamada.masahiro@socionext.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2343
Lines: 81

On 20/04/17 06:56 PM, Masahiro Yamada wrote:
> Include <drm/*.h> instead of relative path from include/drm, then
> remove the -Iinclude/drm compiler flag.
> 
> The fixes of include/drm/ttm/*.h will help driver Makefiles drop
> -Iinclude/drm flag.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

[...]

> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index 6bbd34d..5071d0e 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -30,10 +30,10 @@
>  #ifndef _TTM_BO_DRIVER_H_
>  #define _TTM_BO_DRIVER_H_
>  
> -#include <ttm/ttm_bo_api.h>
> -#include <ttm/ttm_memory.h>
> -#include <ttm/ttm_module.h>
> -#include <ttm/ttm_placement.h>
> +#include <drm/ttm/ttm_bo_api.h>
> +#include <drm/ttm/ttm_memory.h>
> +#include <drm/ttm/ttm_module.h>
> +#include <drm/ttm/ttm_placement.h>
>  #include <drm/drm_mm.h>
>  #include <drm/drm_global.h>
>  #include <drm/drm_vma_manager.h>
> diff --git a/include/drm/ttm/ttm_execbuf_util.h b/include/drm/ttm/ttm_execbuf_util.h
> index 47f35b8..3ad2477 100644
> --- a/include/drm/ttm/ttm_execbuf_util.h
> +++ b/include/drm/ttm/ttm_execbuf_util.h
> @@ -31,7 +31,7 @@
>  #ifndef _TTM_EXECBUF_UTIL_H_
>  #define _TTM_EXECBUF_UTIL_H_
>  
> -#include <ttm/ttm_bo_api.h>
> +#include <drm/ttm/ttm_bo_api.h>
>  #include <linux/list.h>
>  
>  /**
> diff --git a/include/drm/ttm/ttm_lock.h b/include/drm/ttm/ttm_lock.h
> index 2902beb..e8a5fcf 100644
> --- a/include/drm/ttm/ttm_lock.h
> +++ b/include/drm/ttm/ttm_lock.h
> @@ -49,7 +49,7 @@
>  #ifndef _TTM_LOCK_H_
>  #define _TTM_LOCK_H_
>  
> -#include <ttm/ttm_object.h>
> +#include <drm/ttm/ttm_object.h>
>  #include <linux/wait.h>
>  #include <linux/atomic.h>
>  
> diff --git a/include/drm/ttm/ttm_object.h b/include/drm/ttm/ttm_object.h
> index 1487011..1c1b9cc 100644
> --- a/include/drm/ttm/ttm_object.h
> +++ b/include/drm/ttm/ttm_object.h
> @@ -42,7 +42,7 @@
>  #include <linux/kref.h>
>  #include <linux/rcupdate.h>
>  #include <linux/dma-buf.h>
> -#include <ttm/ttm_memory.h>
> +#include <drm/ttm/ttm_memory.h>
>  
>  /**
>   * enum ttm_ref_type
> 

These could all be simplified to

#include "ttm_memory.h"

etc.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer