Message-ID: <1492770644.30293.24.camel@perches.com>
Subject: Re: [PATCH v3] Staging: most: use __func__ instead of the function
 name
From: Joe Perches <joe@perches.com>
To: Chandra Annamaneni <chandra627@gmail.com>
Cc: christian.gromm@microchip.com, andrey.shvetsov@k2l.de,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Fri, 21 Apr 2017 03:30:44 -0700
In-Reply-To: <alpine.DEB.2.20.1704210039130.21893@panther>
References: <alpine.DEB.2.20.1703171242310.3207@turtle>
         <CAEge-i4Y9jfLjRg5pBB7vMcwLKUgPLwfvOCd65yc4_z4pp_nsQ@mail.gmail.com>
         <alpine.DEB.2.20.1704210039130.21893@panther>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 943
Lines: 28

On Fri, 2017-04-21 at 00:40 -0700, Chandra Annamaneni wrote:
> Third Reminder. Please review.

Patience.

> On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote:
> > Second reminder, please review.
[]
> > On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@gmail.com>
> > wrote:
> > 
> >       Change video.c to use %s, __func__ instead of function names.
> >       Warnings flagged by checkpatch.pl
[]
> >       diff --git a/drivers/staging/most/aim-v4l2/video.c
[]
> >       @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
> >       ? ? ? ? struct most_video_dev *mdev = video_drvdata(filp);
> >       ? ? ? ? struct aim_fh *fh;
> > 
> >       -? ? ? ?v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
> >       +? ? ? ?v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);

More likely all of these should be deleted
as these seem to be function tracing logging
and ftrace works well.

see: Documentation/trace/ftrace.txt