Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1038735AbdDUL3X (ORCPT ); Fri, 21 Apr 2017 07:29:23 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:60826 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034387AbdDUL3V (ORCPT ); Fri, 21 Apr 2017 07:29:21 -0400 Date: Fri, 21 Apr 2017 04:29:20 -0700 From: Christoph Hellwig To: NeilBrown Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/11] pktcdvd: use bio_clone_fast() instead of bio_clone() Message-ID: <20170421112920.GE12523@infradead.org> References: <149266645258.27388.14083229348123176454.stgit@noble> <149266672965.27388.264586329955894592.stgit@noble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <149266672965.27388.264586329955894592.stgit@noble> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 16 On Thu, Apr 20, 2017 at 03:38:49PM +1000, NeilBrown wrote: > pktcdvd doesn't change the bi_io_vec of the clone bio, > so it is more efficient to use bio_clone_fast(), and not clone > the bi_io_vec. > This requires providing a bio_set, and it is safest to > provide a dedicated bio_set rather than sharing > fs_bio_set, which filesytems use. > This new bio_set, pkt_bio_set, can also be use for the bio_split() > call as the two allocations (bio_clone_fast, and bio_split) are > independent, neither can block a bio allocated by the other. Looks fine: Reviewed-by: Christoph Hellwig But didn't we decide we want to kill off pktcdvd a while ago?