Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1038847AbdDULeL (ORCPT ); Fri, 21 Apr 2017 07:34:11 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:37387 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1038689AbdDULeJ (ORCPT ); Fri, 21 Apr 2017 07:34:09 -0400 Date: Fri, 21 Apr 2017 04:34:08 -0700 From: Christoph Hellwig To: NeilBrown Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] block: don't check for BIO_MAX_PAGES in blk_bio_segment_split() Message-ID: <20170421113408.GJ12523@infradead.org> References: <149266645258.27388.14083229348123176454.stgit@noble> <149266673048.27388.6882396367486800999.stgit@noble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <149266673048.27388.6882396367486800999.stgit@noble> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 906 Lines: 19 On Thu, Apr 20, 2017 at 03:38:50PM +1000, NeilBrown wrote: > blk_bio_segment_split() makes sure bios have no more than > BIO_MAX_PAGES entries in the bi_io_vec. > This was done because bio_clone_bioset() (when given a > mempool bioset) could not handle larger io_vecs. > > No driver uses bio_clone_bioset() any more, they all > use bio_clone_fast() if anything, and bio_clone_fast() > doesn't clone the bi_io_vec. Hmm. From Jens tree: drivers/lightnvm/pblk-read.c: int_bio = bio_clone_bioset(bio, GFP_KERNEL, fs_bio_set); drivers/md/raid1.c: mbio = bio_clone_bioset_partial(bio, GFP_NOIO, drivers/md/raid1.c: mbio = bio_clone_bioset_partial(bio, GFP_NOIO, I did not see your series touching either of those. They probably don't matter for the code removed as the bios are controlled by the drivers, but the changelog still seems odd.