Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1039957AbdDUNg7 (ORCPT ); Fri, 21 Apr 2017 09:36:59 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52993 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1039615AbdDUNg5 (ORCPT ); Fri, 21 Apr 2017 09:36:57 -0400 Reply-To: pc@us.ibm.com Subject: Re: [PATCH v4 4/7] powerpc/kprobes: Use safer string functions in kprobe_lookup_name() References: <6e14d22994530fb5200c74d1593e73541d3b8028.1492604782.git.naveen.n.rao@linux.vnet.ibm.com> <20170421123320.7344-1-naveen.n.rao@linux.vnet.ibm.com> <5393535f-4469-d6b7-f7ce-256a5612999f@us.ibm.com> To: "Naveen N. Rao" , Michael Ellerman , Masami Hiramatsu Cc: linuxppc-dev@lists.ozlabs.org, Ingo Molnar , linux-kernel@vger.kernel.org From: Paul Clarke Date: Fri, 21 Apr 2017 08:36:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <5393535f-4469-d6b7-f7ce-256a5612999f@us.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17042113-0024-0000-0000-0000164803E8 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006948; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00850484; UDB=6.00420119; IPR=6.00629204; BA=6.00005305; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015125; XFM=3.00000013; UTC=2017-04-21 13:36:52 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17042113-0025-0000-0000-00004A6FE27F Message-Id: <8b6fb142-3cac-fa8a-406a-9f9b0949de07@us.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-21_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704210248 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 394 Lines: 14 On 04/21/2017 08:33 AM, Paul Clarke wrote: > On 04/21/2017 07:33 AM, Naveen N. Rao wrote: >> } else if (name[0] != '.') { >> dot_name[0] = '.'; >> dot_name[1] = '\0'; >> - strncat(dot_name, name, KSYM_NAME_LEN - 2); >> + strlcat(dot_name, name, sizeof(dot_name)); > > and here do: > strncpy(&dot_name[1], name, sizeof(dot_name)); oops. s/sizeof(dot_name)/sizeof(dot_name) - 1/ PC