Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1040470AbdDUPWP (ORCPT ); Fri, 21 Apr 2017 11:22:15 -0400 Received: from mail-ua0-f174.google.com ([209.85.217.174]:35023 "EHLO mail-ua0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1041265AbdDUPWG (ORCPT ); Fri, 21 Apr 2017 11:22:06 -0400 MIME-Version: 1.0 In-Reply-To: <149266672835.27388.5719138070560521601.stgit@noble> References: <149266645258.27388.14083229348123176454.stgit@noble> <149266672835.27388.5719138070560521601.stgit@noble> From: Ming Lei Date: Fri, 21 Apr 2017 23:14:58 +0800 Message-ID: Subject: Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split() To: NeilBrown Cc: Jens Axboe , linux-block , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 486 Lines: 15 On Thu, Apr 20, 2017 at 1:38 PM, NeilBrown wrote: > blk_queue_split() is always called with the last arg being q->bio_split, > where 'q' is the first arg. > > Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses > q->bio_split. > > This is inconsistent and unnecessary. Remove the last arg and always use > q->bio_split inside blk_queue_split() > > Signed-off-by: NeilBrown Reviewed-by: Ming Lei Thanks,