Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161806AbdDUPwx convert rfc822-to-8bit (ORCPT ); Fri, 21 Apr 2017 11:52:53 -0400 Received: from smtp-out6.electric.net ([192.162.217.192]:63170 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161769AbdDUPwm (ORCPT ); Fri, 21 Apr 2017 11:52:42 -0400 From: David Laight To: "'Naveen N. Rao'" , Michael Ellerman , Ingo Molnar CC: "linuxppc-dev@lists.ozlabs.org" , "Masami Hiramatsu" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 4/7] powerpc: kprobes: use safer string functions in kprobe_lookup_name() Thread-Topic: [PATCH v3 4/7] powerpc: kprobes: use safer string functions in kprobe_lookup_name() Thread-Index: AQHSuQz7MjJJmpqW1kW5tfQjNzMlLaHP71eQ Date: Fri, 21 Apr 2017 15:06:37 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFD7B52@AcuExch.aculab.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 260 Lines: 11 From: Naveen N. Rao > Sent: 19 April 2017 13:51 ... > dot_name[0] = '\0'; > - strncat(dot_name, name, sizeof(dot_name) - 1); > + strlcat(dot_name, name, sizeof(dot_name)); ... Is that really zeroing the first byte just so it can append to it? David