Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161748AbdDUPv5 (ORCPT ); Fri, 21 Apr 2017 11:51:57 -0400 Received: from aserp1050.oracle.com ([141.146.126.70]:51614 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161730AbdDUPvu (ORCPT ); Fri, 21 Apr 2017 11:51:50 -0400 Date: Fri, 21 Apr 2017 17:47:34 +0300 From: Dan Carpenter To: Horia =?utf-8?Q?Geant=C4=83?= Cc: Stuart Yoder , "devel@driverdev.osuosl.org" , Haiying Wang , "gregkh@linuxfoundation.org" , Roy Pledge , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] bus: fsl-mc: dpio: fix alter FQ state command Message-ID: <20170421144734.7nr2dnqcltgov74v@mwanda> References: <20170421120018.22232-1-horia.geanta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserp1040.oracle.com [141.146.126.69] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 343 Lines: 10 On Fri, Apr 21, 2017 at 01:50:24PM +0000, Horia Geantă wrote: > Let me know whether keeping code similar would be preferred or not. > Keeping the code similar to the surrounding is never a valid argument but especially not in staging/. If only 1 line is nice in the whole file, at least that's better than nothing. regards, dan carpenter