Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1041977AbdDUSeY (ORCPT ); Fri, 21 Apr 2017 14:34:24 -0400 Received: from mout.web.de ([212.227.15.14]:55077 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161964AbdDUSeM (ORCPT ); Fri, 21 Apr 2017 14:34:12 -0400 Subject: [PATCH v2 05/17] IB/mlx4: Delete four unnecessary return statements From: SF Markus Elfring To: Doug Ledford , Hal Rosenstock , Leon Romanovsky , Majd Dibbiny , Matan Barak , Sean Hefty , Yishai Hadas , linux-rdma@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org References: <1935365a-bd7c-461e-6a84-0c5d3a501fff@users.sourceforge.net> <1492720654.3041.16.camel@redhat.com> Message-ID: Date: Fri, 21 Apr 2017 20:33:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:G425SePoR3UmcHONkLTscK1kcrgt7WhPyRDJo4cHayOm7mFhftH ErVVel3Rr/UZZyU7yj8l4SU7f56pDXAlObXgGh9uVWBmcaAhewTGHMJ687AxvJCEFRTesbX 8V+nmzOzRwmgvQ75cCKtHSUOloLw9RPF/VwBcbOPLrS5mx0MH3K3mC3pFYw6PUnC3lZMCJu HFm/gZLBxY923rG2yrrLQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:qgRzHjDa0jY=:ydj3CayRgarVW3XoSznzJ5 yVAqnEjEWVPkOteA6Dqyyck8AoR/RflY7bLPMqVhBnzMbi2YBhEYtCUf9D2JDJrvMP5/7pYe1 LCz6ANnNGXiYZPLyEVeAVbhDevHL7g5kBScIZb78lZ8OiX9muIROdEihgE33I+kzhbojihdBO 1JkwW12h6aXKgHvC0L/3cyvpH7+09uiIgBBsg8b3hSjHG2Elh05MPDFwL3/OOf06KEWCU4AdJ TXjPbS59zYQA8bqO1ipH1NfFHI7jAhCqQm1qbvBQ2vUKRYu7a/0YMHObwWDOfCQ1gAkfNlgwh jXqTBxUh0BJipUthP5kLd7hBfdiqURD5JHRzJ22jNi5o4fIgo0VU1wOC5iIWOgx5WGxRE43T/ BX3pyp7n1Yai6PqVzl143zl5mANM688hwXGOetQml11UPFo77NkUTn7fuTPWNqhLVJNaT1y3r QWj6D47tKZ9FKyMnv4C2cd+6B+jH/G/+r+66gAbIBFBIzFQ3vvzUXbNDwxiM3szA0wvRYaYD5 plxniXZ1P+S4JP5xKkn0nBiOB3iiD7UZVdxrGq/HiE0lE9wbGDPlvYO31wkApxjsVfu/NCMiq zxg5dgiKCNLg+hWn0upkBrAF6TCPn0dNjebYsM9p+POWzRPZrT2CfK53UYYM3FOy9e/cH2kuB tB0+y+3X3yR67qYfVrR6C+tyS4Y0Yq665/8Lymm8o7/BjpxyCV87Tg8E6GLR9OQXWwxP0OX0N m9+/SrHTMUnGS8tRq3N9EQqTkH7seiplUyhrTrLdz6OMjbU4IRG9XdYa9g8201PgvpuXS1VFS OBZhYhz Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2038 Lines: 62 From: Markus Elfring Date: Fri, 21 Apr 2017 13:10:14 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected functions. Signed-off-by: Markus Elfring --- v2: Changes were rebased on source files from Linux next-20170421. These were recombined as requested by Doug Ledford. drivers/infiniband/hw/mlx4/mad.c | 3 --- drivers/infiniband/hw/mlx4/main.c | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c index d8c27e3ed69a..cf33efce69d2 100644 --- a/drivers/infiniband/hw/mlx4/mad.c +++ b/drivers/infiniband/hw/mlx4/mad.c @@ -1173,7 +1173,6 @@ static void handle_slaves_guid_change(struct mlx4_ib_dev *dev, u8 port_num, out: kfree(in_mad); kfree(out_mad); - return; } void handle_port_mgmt_change_event(struct work_struct *work) @@ -2140,7 +2139,6 @@ void mlx4_ib_tunnels_update_work(struct work_struct *work) mlx4_ib_tunnels_update(dmxw->dev, dmxw->slave, (int) dmxw->port, dmxw->do_init); kfree(dmxw); - return; } static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev, @@ -2268,7 +2266,6 @@ static void mlx4_ib_master_tunnels(struct mlx4_ib_dev *dev, int do_init) /* initialize or tear down tunnel QPs for the master */ for (i = 0; i < dev->dev->caps.num_ports; i++) mlx4_ib_tunnels_update(dev, mlx4_master_func_num(dev->dev), i + 1, do_init); - return; } int mlx4_ib_init_sriov(struct mlx4_ib_dev *dev) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index 0ac670765466..232f556b1121 100644 --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/infiniband/hw/mlx4/main.c @@ -3109,7 +3109,6 @@ static void do_slave_init(struct mlx4_ib_dev *ibdev, int slave, int do_init) } out: kfree(dm); - return; } static void mlx4_ib_handle_catas_error(struct mlx4_ib_dev *ibdev) -- 2.12.2