Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423725AbdDUSY7 (ORCPT ); Fri, 21 Apr 2017 14:24:59 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:36555 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162352AbdDUSYw (ORCPT ); Fri, 21 Apr 2017 14:24:52 -0400 MIME-Version: 1.0 In-Reply-To: <1492780055-4892-2-git-send-email-daniel.baluta@nxp.com> References: <1492780055-4892-1-git-send-email-daniel.baluta@nxp.com> <1492780055-4892-2-git-send-email-daniel.baluta@nxp.com> From: Arnd Bergmann Date: Fri, 21 Apr 2017 16:46:04 +0200 X-Google-Sender-Auth: -bLS0hVIQrVXsZdcymSfXVH-9Mo Message-ID: Subject: Re: [PATCH 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning To: Daniel Baluta Cc: Mark Brown , tiwai@suse.com, Charles Keepax , Liam Girdwood , patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1043 Lines: 25 On Fri, Apr 21, 2017 at 3:07 PM, Daniel Baluta wrote: > The new PLL configuration code triggers a harmless warning: > > sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': > sound/soc/codecs/wm8960.c:735:3: error: 'best_freq_out' may be used > uninitialized in this function [-Werror=maybe-uninitialized] > wm8960_set_pll(codec, freq_in, best_freq_out); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/soc/codecs/wm8960.c:699:12: note: 'best_freq_out' was declared > here > > Fixes: 84fdc00d519f ("ASoC: codec: wm9860: Refactor PLL out freq search") > Fixes: 303e8954af8d ("ASoC: codec: wm8960: Stop when a matching PLL freq is found") > Suggested-by: Arnd Bergmann > Signed-off-by: Daniel Baluta > --- > Arnd, > > I agree that your code was more both humans and gcc anyhow > for consistency with wm8960_configure_sysclk function I preferred > to keep the "if(..) break" statements. How about changing both functions the same way then? Arnd