Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1042066AbdDUShT (ORCPT ); Fri, 21 Apr 2017 14:37:19 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:34849 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1042038AbdDUSgw (ORCPT ); Fri, 21 Apr 2017 14:36:52 -0400 Subject: Re: [PATCH] lightnvm: propagate pblk_init return to userspace To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= , Rakesh Pandit References: <20170420182356.GA7866@hercules.tuxera.com> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: Date: Fri, 21 Apr 2017 20:11:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 23 On 04/21/2017 05:07 PM, Javier González wrote: >> On 20 Apr 2017, at 20.23, Rakesh Pandit wrote: >> >> From userspace calling ioctl(NVM_DEV_CREATE) was returning ENOMEM for >> invalid arguments even though pblk (pblk_init) was returning correctly >> -EINVAL to nvm_create_tgt inside core. This patch propagates the >> correct return value to userspace. >> >> Because pblk was introduced recently this only needs to go in 4.12. >> >> Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target") >> Signed-off-by: Rakesh Pandit >> > > Looks good. > > Reviewed-by: Javier González > > Javier > Jens, would you pick this up as well? :)