Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162267AbdDUSl0 (ORCPT ); Fri, 21 Apr 2017 14:41:26 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:36723 "EHLO mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162206AbdDUSlW (ORCPT ); Fri, 21 Apr 2017 14:41:22 -0400 Subject: Re: [PATCH] lightnvm: propagate pblk_init return to userspace To: =?UTF-8?Q?Matias_Bj=c3=b8rling?= , =?UTF-8?Q?Javier_Gonz=c3=a1lez?= , Rakesh Pandit References: <20170420182356.GA7866@hercules.tuxera.com> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org From: Jens Axboe Message-ID: <96dcf7b9-542f-4daf-7653-07cd54d0f86d@kernel.dk> Date: Fri, 21 Apr 2017 12:41:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 29 On 04/21/2017 12:11 PM, Matias Bj?rling wrote: > On 04/21/2017 05:07 PM, Javier Gonz?lez wrote: >>> On 20 Apr 2017, at 20.23, Rakesh Pandit wrote: >>> >>> From userspace calling ioctl(NVM_DEV_CREATE) was returning ENOMEM for >>> invalid arguments even though pblk (pblk_init) was returning correctly >>> -EINVAL to nvm_create_tgt inside core. This patch propagates the >>> correct return value to userspace. >>> >>> Because pblk was introduced recently this only needs to go in 4.12. >>> >>> Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target") >>> Signed-off-by: Rakesh Pandit >>> >> >> Looks good. >> >> Reviewed-by: Javier Gonz?lez >> >> Javier >> > > > Jens, would you pick this up as well? :) Done, thanks Rakesh. -- Jens Axboe