Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1042332AbdDUSpe (ORCPT ); Fri, 21 Apr 2017 14:45:34 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35072 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1041972AbdDUSpc (ORCPT ); Fri, 21 Apr 2017 14:45:32 -0400 MIME-Version: 1.0 In-Reply-To: <1492780055-4892-3-git-send-email-daniel.baluta@nxp.com> References: <1492780055-4892-1-git-send-email-daniel.baluta@nxp.com> <1492780055-4892-3-git-send-email-daniel.baluta@nxp.com> From: Arnd Bergmann Date: Fri, 21 Apr 2017 16:44:25 +0200 X-Google-Sender-Auth: VSupbpYtNQyeTAldaXV2pIwRwfc Message-ID: Subject: Re: [PATCH 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL To: Daniel Baluta Cc: Mark Brown , tiwai@suse.com, Charles Keepax , Liam Girdwood , patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1410 Lines: 35 On Fri, Apr 21, 2017 at 3:07 PM, Daniel Baluta wrote: > Bitclk is derived from sysclk using bclk_divs. > Sysclk can be derived in two ways: > (1) directly from MLCK > (2) MCLK via PLL > > Commit 3c01b9ee2ab9d0d ("ASoC: codec: wm8960: Relax bit clock > computation") > relaxed bitclk computation when sysclk is directly derived from MCLK. > > Lets do the same thing when sysclk is derived via PLL. > > Signed-off-by: Daniel Baluta > --- > Here, I forced the following harmless initialization: > > *sysclk_idx = *dac_idx = *bclk_idx = -1; > > otherwise I would trigger a gcc false positive warning: > > sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': > sound/soc/codecs/wm8960.c:810:46: warning: 'j' may be used uninitialized > in this function [-Wmaybe-uninitialized] > snd_soc_update_bits(codec, WM8960_CLOCK1, 0x7 << 6, j << 6); > ~~^~~~ > sound/soc/codecs/wm8960.c:806:44: warning: 'i' may be used uninitialized > in this function [-Wmaybe-uninitialized] > snd_soc_update_bits(codec, WM8960_CLOCK1, 3 << 1, i << 1); > ~~^~~~ I saw the same warning earlier, but it was gone after the rework I posted the other day. Please try if that works for you as well, I think that would be better than a bogus initialization. Arnd