Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423826AbdDUSqr (ORCPT ); Fri, 21 Apr 2017 14:46:47 -0400 Received: from mail-ua0-f174.google.com ([209.85.217.174]:35177 "EHLO mail-ua0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161947AbdDUSqp (ORCPT ); Fri, 21 Apr 2017 14:46:45 -0400 MIME-Version: 1.0 In-Reply-To: <20170421113408.GJ12523@infradead.org> References: <149266645258.27388.14083229348123176454.stgit@noble> <149266673048.27388.6882396367486800999.stgit@noble> <20170421113408.GJ12523@infradead.org> From: Ming Lei Date: Fri, 21 Apr 2017 23:48:59 +0800 Message-ID: Subject: Re: [PATCH 11/11] block: don't check for BIO_MAX_PAGES in blk_bio_segment_split() To: Christoph Hellwig Cc: NeilBrown , Jens Axboe , linux-block , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 24 On Fri, Apr 21, 2017 at 7:34 PM, Christoph Hellwig wrote: > On Thu, Apr 20, 2017 at 03:38:50PM +1000, NeilBrown wrote: >> blk_bio_segment_split() makes sure bios have no more than >> BIO_MAX_PAGES entries in the bi_io_vec. >> This was done because bio_clone_bioset() (when given a >> mempool bioset) could not handle larger io_vecs. >> >> No driver uses bio_clone_bioset() any more, they all >> use bio_clone_fast() if anything, and bio_clone_fast() >> doesn't clone the bi_io_vec. > > Hmm. From Jens tree: > > drivers/lightnvm/pblk-read.c: int_bio = bio_clone_bioset(bio, GFP_KERNEL, fs_bio_set); > drivers/md/raid1.c: mbio = bio_clone_bioset_partial(bio, GFP_NOIO, > drivers/md/raid1.c: mbio = bio_clone_bioset_partial(bio, GFP_NOIO, Btrfs use bio_clone_bioset() too: fs/btrfs/extent_io.c:2703: new = bio_clone_bioset(bio, gfp_mask, btrfs_bioset); Thanks, Ming Lei