Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162300AbdDUSrj (ORCPT ); Fri, 21 Apr 2017 14:47:39 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54096 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162213AbdDUSre (ORCPT ); Fri, 21 Apr 2017 14:47:34 -0400 Date: Fri, 21 Apr 2017 11:47:31 -0700 From: Josh Triplett To: priyalee.kushwaha@intel.com Cc: paulmck@linux.vnet.ibm.com, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk Message-ID: <20170421184721.GA28159@cloud> References: <1ad554b0025913fedf4ec3c7953d1a42fe1f0dde.1492879165.git.priyalee.kushwaha@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ad554b0025913fedf4ec3c7953d1a42fe1f0dde.1492879165.git.priyalee.kushwaha@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 33 On Sat, Apr 22, 2017 at 10:17:11AM -0700, priyalee.kushwaha@intel.com wrote: > From: Priyalee Kushwaha > > Most OS distribution have awk in /usr/bin not in /bin > Without this patch, kernel-devsrc fails to build as > runtime dependency for srcu-cbmc script /bin/awk is > not found. > > Signed-off-by: Kushwaha, Priyalee For anyone that has it in /bin/awk, does it have a compatibility symlink from /usr/bin/awk (or vice versa), or not? If not, then this would break the build for those folks. We could just drop the shebang and the executable bit, and run "awk -f modify_srcu.awk" from whatever script invokes this. > tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk > index 8ff8904..c9e8bc5 100755 > --- a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk > +++ b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk > @@ -1,4 +1,4 @@ > -#!/bin/awk -f > +#!/usr/bin/awk -f > > # Modify SRCU for formal verification. The first argument should be srcu.h and > # the second should be srcu.c. Outputs modified srcu.h and srcu.c into the > -- > 2.10.0 >