Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424148AbdDUSxp (ORCPT ); Fri, 21 Apr 2017 14:53:45 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:36080 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424006AbdDUSxm (ORCPT ); Fri, 21 Apr 2017 14:53:42 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt From: Alexander Kochetkov In-Reply-To: <2f44a2db-da7a-2ca9-ea5e-6cc551c3008c@ti.com> Date: Fri, 21 Apr 2017 17:42:14 +0300 Cc: Florian Fainelli , netdev@vger.kernel.org, LKML , Sergei Shtylyov , Madalin Bucur Message-Id: <5C544A66-7895-4543-808B-764A7B1A4E0A@gmail.com> References: <1492686004-30527-1-git-send-email-al.kochet@gmail.com> <1492686004-30527-2-git-send-email-al.kochet@gmail.com> <2f44a2db-da7a-2ca9-ea5e-6cc551c3008c@ti.com> To: Roger Quadros X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v3LIsU0B026827 Content-Length: 1114 Lines: 23 > 21 апр. 2017 г., в 17:18, Roger Quadros написал(а): > > I think the following commit broke functionality with interrupt driven PHYs > 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.") Probably this one[1] broke, according to Alexandre’s commit[2]. And it was since Nov 16 2015. But it was hidden by some other commits. For Roger problem became visible after 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.»), For my problem became visible after 529ed1275263 ("net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause»). As commit 529ed1275263 removed SUPPORTED_Pause flag from PHY advertising property and genphy_config_aneg() began to skip PHY auto-negotiation. Alexander. [1] Fixes: 321beec5047a (net: phy: Use interrupts when available in NOLINK state) https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=321beec5047af83db90c88114b7e664b156f49fe [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=99f81afc139c6edd14d77a91ee91685a414a1c66