Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424761AbdDUTTj (ORCPT ); Fri, 21 Apr 2017 15:19:39 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33550 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424665AbdDUTTf (ORCPT ); Fri, 21 Apr 2017 15:19:35 -0400 Subject: Re: Unchecked flags in statx(2) [Should be fixed before 4.11-final?] To: Andreas Dilger References: <18703.1492779716@warthog.procyon.org.uk> <5d662912-5cbe-a171-2273-50bbbedbc880@gmail.com> Cc: mtk.manpages@gmail.com, David Howells , lkml , linux-fsdevel , hch@infradead.org From: "Michael Kerrisk (man-pages)" Message-ID: <6b5580c6-e163-0404-17e4-6c1c3777bc76@gmail.com> Date: Fri, 21 Apr 2017 21:19:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 35 Hello Andreas, On 04/21/2017 08:16 PM, Andreas Dilger wrote: > On Apr 21, 2017, at 7:13 AM, Michael Kerrisk (man-pages) wrote: >> >> On 04/21/2017 03:01 PM, David Howells wrote: >>> Michael Kerrisk (man-pages) wrote: >> >>> (3) There's no problem with asking for extra bits, even if the running >>> kerneldoes not support them, because the kernel tells you in its >>> response what fields it actually gave you. >> >> It's this piece that I overlooked. Makes sense, of course. >> Sorry for the noise! > > I agree with David that we don't want to return an error if the application > asks for more bits than the kernel supports, otherwise the interface would > be useless. Yes, it's clear to me now. > Maybe this implies that this needs to be explained more clearly in the > statx man page? Precisely; my thought also. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/