Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424792AbdDUTT6 (ORCPT ); Fri, 21 Apr 2017 15:19:58 -0400 Received: from mail-io0-f173.google.com ([209.85.223.173]:34743 "EHLO mail-io0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424749AbdDUTTi (ORCPT ); Fri, 21 Apr 2017 15:19:38 -0400 Subject: Re: mtip32xx: add a status field to struct mtip_cmd To: Christoph Hellwig References: <933d95b1-ee6c-eb74-9197-32852e7f7728@canonical.com> <20170421143756.GA31311@lst.de> Cc: Colin Ian King , Johannes Thumshirn , "linux-kernel@vger.kernel.org" From: Jens Axboe Message-ID: <961fde7a-bac3-d922-45d5-3f2a61920156@kernel.dk> Date: Fri, 21 Apr 2017 08:47:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170421143756.GA31311@lst.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 528 Lines: 19 On 04/21/2017 08:37 AM, Christoph Hellwig wrote: > On Fri, Apr 21, 2017 at 08:14:03AM -0600, Jens Axboe wrote: >> From: Jens Axboe >> Subject: [PATCH] mtip32xx: fix dereference of stack garbage >> >> We need to get the command payload from the request before >> we attempt to dereference it. >> >> Fixes: 4dda4735c581 ("mtip32xx: add a status field to struct mtip_cmd") >> Signed-off-by: Jens Axboe > > Looks fine: > > Reviewed-by: Christoph Hellwig Pushed, thanks. -- Jens Axboe